diff -uwrN aria2c-1.0.1.orig/src/SocketCore.cc aria2c-1.0.1/src/SocketCore.cc --- aria2c-1.0.1.orig/src/SocketCore.cc Mon Nov 24 06:20:01 2008 +++ aria2c-1.0.1/src/SocketCore.cc Tue Nov 25 12:06:05 2008 @@ -174,8 +174,8 @@ if(fd == -1) { continue; } - SOCKOPT_T sockopt = 1; - if(setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &sockopt, sizeof(socklen_t)) < 0) { + int sockopt = 1; + if(setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, (a2_sockopt_t) &sockopt, sizeof(sockopt)) < 0) { CLOSE(fd); continue; } @@ -204,7 +204,7 @@ struct sockaddr_storage sockaddr; socklen_t len = sizeof(sockaddr); sock_t fd; - while((fd = accept(sockfd, reinterpret_cast(&sockaddr), &len)) == -1 && errno == EINTR); + while((fd = accept(sockfd, reinterpret_cast(&sockaddr), &len)) == -1 && SOCKET_ERRNO == EINTR); if(fd == -1) { throw DlAbortEx(StringFormat(EX_SOCKET_ACCEPT, errorMsg()).str()); } @@ -256,8 +256,8 @@ if(fd == -1) { continue; } - SOCKOPT_T sockopt = 1; - if(setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &sockopt, sizeof(socklen_t)) < 0) { + int sockopt = 1; + if(setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, (a2_sockopt_t) &sockopt, sizeof(sockopt)) < 0) { CLOSE(fd); continue; } @@ -498,9 +498,9 @@ _wantWrite = false; if(!secure) { - while((ret = send(sockfd, data, len, 0)) == -1 && errno == EINTR); + while((ret = send(sockfd, data, len, 0)) == -1 && SOCKET_ERRNO == EINTR); if(ret == -1) { - if(errno == EAGAIN) { + if(SOCKET_ERRNO == EAGAIN) { _wantWrite = true; ret = 0; } else { @@ -546,10 +546,10 @@ _wantWrite = false; if(!secure) { - while((ret = recv(sockfd, data, len, 0)) == -1 && errno == EINTR); + while((ret = recv(sockfd, data, len, 0)) == -1 && SOCKET_ERRNO == EINTR); if(ret == -1) { - if(errno == EAGAIN) { + if(SOCKET_ERRNO == EAGAIN) { _wantRead = true; ret = 0; } else { @@ -597,9 +597,9 @@ _wantWrite = false; if(!secure) { - while((ret = recv(sockfd, data, len, MSG_PEEK)) == -1 && errno == EINTR); + while((ret = recv(sockfd, data, len, MSG_PEEK)) == -1 && SOCKET_ERRNO == EINTR); if(ret == -1) { - if(errno == EAGAIN) { + if(SOCKET_ERRNO == EAGAIN) { _wantRead = true; ret = 0; } else { @@ -984,11 +984,11 @@ struct addrinfo* rp; ssize_t r = -1; for(rp = res; rp; rp = rp->ai_next) { - while((r = sendto(sockfd, data, len, 0, rp->ai_addr, rp->ai_addrlen)) == -1 && EINTR == errno); + while((r = sendto(sockfd, data, len, 0, rp->ai_addr, rp->ai_addrlen)) == -1 && EINTR == SOCKET_ERRNO); if(r == static_cast(len)) { break; } - if(r == -1 && errno == EAGAIN) { + if(r == -1 && SOCKET_ERRNO == EAGAIN) { _wantWrite = true; r = 0; break; @@ -1012,9 +1012,9 @@ struct sockaddr* addrp = reinterpret_cast(&sockaddr); ssize_t r; while((r = recvfrom(sockfd, data, len, 0, addrp, &sockaddrlen)) == -1 && - EINTR == errno); + EINTR == SOCKET_ERRNO); if(r == -1) { - if(errno == EAGAIN) { + if(SOCKET_ERRNO == EAGAIN) { _wantRead = true; r = 0; } else { @@ -1029,9 +1029,10 @@ std::string SocketCore::getSocketError() const { - SOCKOPT_T error; + int error; socklen_t optlen = sizeof(error); - if(getsockopt(sockfd, SOL_SOCKET, SO_ERROR, &error, &optlen) == -1) { + + if(getsockopt(sockfd, SOL_SOCKET, SO_ERROR, (a2_sockopt_t) &error, &optlen) == -1) { throw DlAbortEx(StringFormat("Failed to get socket error: %s", errorMsg()).str()); } diff -uwrN aria2c-1.0.1.orig/src/a2netcompat.h aria2c-1.0.1/src/a2netcompat.h --- aria2c-1.0.1.orig/src/a2netcompat.h Mon Nov 24 06:20:01 2008 +++ aria2c-1.0.1/src/a2netcompat.h Tue Nov 25 12:03:35 2008 @@ -50,12 +50,12 @@ #endif // !__CYGWIN__ #ifdef __MINGW32__ -# define SOCKOPT_T char +# define a2_sockopt_t char * # define HAVE_GETADDRINFO # undef HAVE_GAI_STRERROR # undef gai_strerror #else -# define SOCKOPT_T int +# define a2_sockopt_t int * #endif // __MINGW32__ #ifdef HAVE_NETDB_H diff -uwrN aria2c-1.0.1.orig/test/SocketCoreTest.cc aria2c-1.0.1/test/SocketCoreTest.cc --- aria2c-1.0.1.orig/test/SocketCoreTest.cc Mon Nov 24 06:19:53 2008 +++ aria2c-1.0.1/test/SocketCoreTest.cc Tue Nov 25 12:04:21 2008 @@ -9,6 +9,7 @@ CPPUNIT_TEST_SUITE(SocketCoreTest); CPPUNIT_TEST(testWriteAndReadDatagram); + CPPUNIT_TEST(testGetSocketError); CPPUNIT_TEST_SUITE_END(); public: void setUp() {} @@ -16,6 +17,7 @@ void tearDown() {} void testWriteAndReadDatagram(); + void testGetSocketError(); }; @@ -57,6 +59,14 @@ std::cerr << e.stackTrace() << std::endl; CPPUNIT_FAIL("exception thrown"); } +} + +void SocketCoreTest::testGetSocketError() +{ + SocketCore s; + s.bind(0); + // See there is no error at this point + CPPUNIT_ASSERT_EQUAL(std::string(""), s.getSocketError()); } } // namespace aria2